From 6415ca2e68f1cad2b902c7d9c5c5c282724aba9c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eduard=20Bardaj=C3=AD=20Puig?= Date: Thu, 11 Aug 2022 15:44:27 +0200 Subject: [PATCH] Update utils.js Added a comment to clarify why reply messages are not sent when their length is 1. Alternatively we could also create a function with a descriptive name of the check being performed, ```js function hasMessage(encoder) { return encoding.length(encoder) > 1; } ``` The `if` statement would then look something like, ```js if (hasMessage(encoder)) { send(...); } ``` Thoughts? --- bin/utils.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/bin/utils.js b/bin/utils.js index 05f8b88..71feb7e 100644 --- a/bin/utils.js +++ b/bin/utils.js @@ -168,6 +168,10 @@ const messageListener = (conn, doc, message) => { case messageSync: encoding.writeVarUint(encoder, messageSync) syncProtocol.readSyncMessage(decoder, encoder, doc, null) + + // If the `encoder` only contains the type of reply message and no + // message, there is no need to send the message. When `encoder` only + // contains the type of reply, its length is 1. if (encoding.length(encoder) > 1) { send(doc, conn, encoding.toUint8Array(encoder)) }