MTS/yjs-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update utils.js

Browse Source 
Added a comment to clarify why reply messages are not sent when their length is 1. Alternatively we could also create a function with a descriptive name of the check being performed,

```js
function hasMessage(encoder) {
    return encoding.length(encoder) > 1;
}
```

The `if` statement would then look something like,

```js
if (hasMessage(encoder)) {
    send(...);
}
```

Thoughts?
This commit is contained in:
Eduard Bardají Puig 2022-08-11 15:44:27 +02:00 committed by GitHub
parent 625a9d52ba
commit 6415ca2e68
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bin/utils.js
View File

@ -168,6 +168,10 @@ const messageListener = (conn, doc, message) => {
case messageSync: case messageSync:
encoding.writeVarUint(encoder, messageSync) encoding.writeVarUint(encoder, messageSync)
syncProtocol.readSyncMessage(decoder, encoder, doc, null) syncProtocol.readSyncMessage(decoder, encoder, doc, null)
// If the `encoder` only contains the type of reply message and no
// message, there is no need to send the message. When `encoder` only
// contains the type of reply, its length is 1.
if (encoding.length(encoder) > 1) { if (encoding.length(encoder) > 1) {
send(doc, conn, encoding.toUint8Array(encoder)) send(doc, conn, encoding.toUint8Array(encoder))
} }