From 399d36ff43ab0b3c77c2ef4ed044ef90f4766dff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Istv=C3=A1n=20Koren?= Date: Sat, 28 Sep 2019 10:19:57 +0200 Subject: [PATCH] Fixing README.md typos and errors Mainly, the provider const was undefined (as it was wsProvider). Along this fix I corrected some typos. --- README.md | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 132bfd9..78c5d02 100644 --- a/README.md +++ b/README.md @@ -1,12 +1,12 @@ ### Websocket Provider -The websocket provider implements a classical client server model. Clients connect to a single endpoint over websocket. The server distributes awareness information and document updates among clients. +The Websocket Provider implements a classical client server model. Clients connect to a single endpoint over Websocket. The server distributes awareness information and document updates among clients. The Websocket Provider is a solid choice if you want a central source that handles authentication and authorization. Websockets also send header information and cookies, so you can use existing authentication mechanisms with this server. * Supports cross-tab communication. When you open the same document in the same browser, changes on the document are exchanged via cross-tab communication ([Broadcast Channel](https://developer.mozilla.org/en-US/docs/Web/API/Broadcast_Channel_API) and [localStorage](https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage) as fallback). -* Supports exange of awareness information (e.g. cursors) +* Supports exchange of awareness information (e.g. cursors). ##### Client Code: @@ -17,7 +17,7 @@ import { WebsocketProvider } from 'yjs/provider/websocket.js' const doc = new Y.Doc() const wsProvider = new WebsocketProvider('ws://localhost:1234', 'my-roomname', doc) -provider.on('status', event => { +wsProvider.on('status', event => { console.log(event.status) // logs "connected" or "disconnected" }) ``` @@ -25,9 +25,11 @@ provider.on('status', event => { ##### Start a Websocket Server: ```sh -PORT=1234 node ./node_modules/yjs/provider/websocket/server.js +PORT=1234 npx y-websocket-server ``` +Since npm symlinks the `y-websocket-server` executable from your local `./node_modules/.bin` folder, you can simply run npx. The `PORT` environment variable already defaults to 1234. + **Websocket Server with Persistence** Persist document updates in a LevelDB database. @@ -44,7 +46,7 @@ These are mere suggestions how you could scale your server environment. **Option 1:** Websocket servers communicate with each other via a PubSub server. A room is represented by a PubSub channel. The downside of this approach is that the same shared document may be handled by many servers. But the upside is that this approach is fault tolerant, does not have a single point of failure, and is fit for route balancing. -**Option 2:** Sharding with *consistent hashing*. Each document is handled by a unique server. This patterns requires an entity, like etcd, that performs regular health checks and manages servers. Based on the list of available servers (which is managed by etcd) a proxy calculates which server is responsible for each requested document. The disadvantage of this approach is that it is that load distribution may not be fair. Still, this approach may be the preferred solution if you want to store the shared document in a database - e.g. for indexing. +**Option 2:** Sharding with *consistent hashing*. Each document is handled by a unique server. This pattern requires an entity, like etcd, that performs regular health checks and manages servers. Based on the list of available servers (which is managed by etcd) a proxy calculates which server is responsible for each requested document. The disadvantage of this approach is that load distribution may not be fair. Still, this approach may be the preferred solution if you want to store the shared document in a database - e.g. for indexing. ### License